Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: 5.0.1 -> 5.0.2 #65104

Merged
merged 1 commit into from Aug 20, 2019
Merged

swift: 5.0.1 -> 5.0.2 #65104

merged 1 commit into from Aug 20, 2019

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Jul 19, 2019

I updated Swift to the recent release and removed a superfluous substitution.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mroi
swift: 5.0.1 -> 5.0.2
4f28fb6 
update Swift and remove superfluous substitution
@ofborg ofborg bot requested a review from dtzWill July 19, 2019 19:59
@mmahut
Copy link
Member

mmahut commented Jul 23, 2019

@GrahamcOfBorg build swift

1 similar comment
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg build swift

dtzWill
dtzWill approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dropping the dead substitution!

@mmahut mmahut merged commit ed3cee7 into NixOS:master Aug 20, 2019
@mroi
Copy link
Contributor Author

mroi commented Aug 21, 2019

You’re welcome. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mroi @mmahut @dtzWill