Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault-bin: init at 1.1.3 #65166

Merged
merged 2 commits into from Aug 4, 2019
Merged

vault-bin: init at 1.1.3 #65166

merged 2 commits into from Aug 4, 2019

Conversation

PsyanticY
Copy link
Contributor

@PsyanticY PsyanticY commented Jul 20, 2019 •
edited

Currently the vault module do not include the ui part of it due to some complications (check this pr: #49082) I think instead of doing the packaging from source we can use the binary Hashicorp is providing that includes the UI.
This is still just a draft and some more work will be made (how to handle darwin and udpate the module with a UI option) if we agree on proceeding using this method.
cc @LnL7 @rushmorem @offline @pradeepchhetri

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker
Copy link
Contributor

I do not agree to package vault from prebuilt binary by default, if you have a good reason we can make separate package called vault-bin, but I want to first hear which issues you had building vault with UI?

@PsyanticY
Copy link
Contributor Author

Hi @offlinehacker Please have a look here #49082

@PsyanticY PsyanticY force-pushed the vault-with-ui branch 2 times, most recently from c75792e to 2e2781a Compare July 23, 2019 16:19
@PsyanticY PsyanticY changed the title [WIP] vault: update packaging to include the UI vault-bin: init at 1.1.3 Jul 23, 2019
@PsyanticY
Copy link
Contributor Author

PsyanticY commented Jul 23, 2019 •
edited

per @offlinehacker and @LnL7 recommendation, Proceeding with a separate.

@PsyanticY PsyanticY marked this pull request as ready for review July 23, 2019 17:15
@offlinehacker
Copy link
Contributor

I assume it's statically compiled and that's why you didn't need patchelf?

@ofborg ofborg bot requested a review from offlinehacker July 24, 2019 09:43
@PsyanticY PsyanticY force-pushed the vault-with-ui branch 2 times, most recently from a350bca to dc810f7 Compare July 24, 2019 09:57
@PsyanticY PsyanticY closed this Jul 24, 2019
@PsyanticY PsyanticY reopened this Jul 24, 2019
@PsyanticY
Copy link
Contributor Author

@offlinehacker yeah it is statically compiled so no need for patchelf

@PsyanticY PsyanticY force-pushed the vault-with-ui branch 3 times, most recently from 3f6eb29 to ec38124 Compare July 25, 2019 14:55
@PsyanticY
vault-bin: init at 1.1.3
f403684 
This binray contain the UI part of HashiCorp Vault that we were not able to build it due to the need to generate a very big yarn file. NixOS#49082
@PsyanticY
Copy link
Contributor Author

@offlinehacker Should be good now Thanks for the help.

@ofborg ofborg bot requested a review from offlinehacker July 25, 2019 15:08
@offlinehacker
Copy link
Contributor

Thanks, looks good now. I will just do a minor stylistic change, and merge to master 🙂

@PsyanticY
Copy link
Contributor Author

@offlinehacker thanks

@ofborg ofborg bot requested a review from offlinehacker August 4, 2019 10:34
@offlinehacker offlinehacker merged commit e2cd85d into NixOS:master Aug 4, 2019
@PsyanticY PsyanticY deleted the vault-with-ui branch August 4, 2019 16:40
@PsyanticY PsyanticY mentioned this pull request Aug 29, 2019
Closed
@ljani ljani mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@rushmorem rushmorem Awaiting requested review from rushmorem

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PsyanticY @offlinehacker