Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helio-workstation: init at 2.2 #65238

Merged
merged 1 commit into from Jul 23, 2019
Merged

helio-workstation: init at 2.2 #65238

merged 1 commit into from Jul 23, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jul 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jul 21, 2019

@GrahamcOfBorg build helio-workstation

@mmahut
Copy link
Member

mmahut commented Jul 21, 2019

Fails on aarch64-linux. https://logs.nix.ci/?key=nixos/nixpkgs.65238&attempt_id=d23bb180-e45f-481d-810f-37dee2138939

@symphorien
Copy link
Member

Ran nix-review, Helio seems to work fine here.

worldofpeace
worldofpeace suggested changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you install the icons and desktop file at

You'll need to patch the desktop file to use a nix store path.

pkgs/applications/audio/helio-workstation/default.nix Show resolved Hide resolved
pkgs/applications/audio/helio-workstation/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/helio-workstation/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/helio-workstation/default.nix Show resolved Hide resolved
pkgs/applications/audio/helio-workstation/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

bump #65238 (comment)

@worldofpeace
Copy link
Contributor

Comment in #65238 (review) still stands

@suhr
Copy link
Contributor Author

suhr commented Jul 22, 2019

Done. I replaced mesa back with libGL, because otherwise Helio doesn't compile.

worldofpeace
worldofpeace approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested execution again and verified the contents of desktop file.

@worldofpeace worldofpeace merged commit 3f884a1 into NixOS:master Jul 23, 2019
@suhr suhr deleted the helio branch July 23, 2019 08:10
@suhr suhr mentioned this pull request Jul 23, 2019
Closed
@magnetophon
Copy link
Member

@suhr Thanks for the package.
It doesn't make any sounds here though.

In the settings I can choose between alsa and jack, but there aren't any of the jack settings shown, like buffersize.
Helio also doesn't create any ports on jack.
Finally, it doesn't see any of my plugins.

Any idea what's going on?

I'm on NixOS unstable.

@suhr
Copy link
Contributor Author

suhr commented Sep 20, 2020

@magnetophon I fixed the issue with JACK in #94950.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suhr @mmahut @symphorien @worldofpeace @magnetophon