Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: gitlab-workhorse requires exiftool on path #65074

Merged
merged 1 commit into from Jul 22, 2019
Merged

nixos/gitlab: gitlab-workhorse requires exiftool on path #65074

merged 1 commit into from Jul 22, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Jul 19, 2019

Motivation for this change

Gitlab workhorse fails while processing uploaded images, because exiftool is missing on path:

gitlab-workhorse    time="2019-07-19T14:02:28+02:00" level=info msg="running exiftool to remove any metadata" correlation_id=d4kAAM1G1W1 filename=IMG_20190719_134641.jpg

@GrahamcOfBorg test gitlab
cc @globin

please backport this to 19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@globin globin merged commit bbd4a0c into NixOS:master Jul 22, 2019
@globin
Copy link
Member

globin commented Jul 22, 2019

Backported in 248a3d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @globin