Replace ad hoc throttling fix with throttled #115
Conversation
|
Since it is a new service, we could backport throttled as well to stable. |
|
This should be now in 19.09. Can you update the PR? |
| ]; | ||
|
|
||
| # Force S3 sleep mode. See README.wiki for details. | ||
| boot.kernelParams = [ "mem_sleep_default=deep" ]; | ||
|
|
||
| # touchpad goes over i2c | ||
| boot.blacklistedKernelModules = [ "psmouse" ]; | ||
|
|
||
| services.throttled.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Should we not rather update the cpu-throttling-bug module?
There was a problem hiding this comment.
No strong opinion here. A single option line could be also good enough.
There was a problem hiding this comment.
The module made sense because there were several things to do. Having a whole module which just enables a single option seems like overkill. Better to just enable it.
michaelpj
force-pushed
the
imp/throttled
branch
from
c341ec1 to
664ee33
Compare
|
Ah yes, I forgot about this. Updated - I changed some new users of |
|
Ironically, Lenovo might finally be going to fix it. |
|
This one was just merged and also has the module: https://github.com/NixOS/nixos-hardware/pull/125/files |
`throttled` is a service designed to fix the same CPU throttling bug, but it's an actively maintainted upstream project that we can use.
michaelpj
force-pushed
the
imp/throttled
branch
from
664ee33 to
2bf9422
Compare
|
Updated to catch that one too! |
throttledis a service designed to fix the same CPU throttling bug,but it's an actively maintainted upstream project that we can use.
I'm unsure if we should make this change now.
throttledis only in since May, so this will only work for people onnixos-unstable. I don't know what our policy should be wrt to that.