Can you include a fix for #64984?

@rnhmjoj I can't reproduce that. Works for me, I'm typing this in 1.7.0! ;)

@GrahamcOfBorg build qutebrowser

Fails to run after build.

Fatal error: PyQt5.QtQml is required to run qutebrowser but could not be imported! Maybe it's not installed?

The error encountered was:
No module named 'PyQt5.QtQml'

That's odd. Any idea how I can reproduce it?

Try to build it with nix-review.

You need to add wrapQtAppsHook to nativeBuildInputs.

@mmahut Thanks, I didn't know about that tool.
The help has led me to stumble on nix-review pr 65150, and now I'm in a nix-shell, and I don't know how to continue...

@magnetophon any Qt application that uses plugins needs to load these at runtime. It will look for plugins in some fixed path or following an env variable. So, qutebrowser will not run in a (pure) nix-shell or from result/bin/qutebrowser without being wrapped. If it does it's probably because it picked up impurities from your profile, because you have qutebrowser installed.

I think (I have not tried it yet) wrapQtAppsHook automatically set QT_PLUGIN_PATH and QML2_IMPORT_PATH so you don't have to specify all the plugins (see bbefa95).

@rnhmjoj Thanks, but that's the part I got from @worldofpeace already.
What I still don't know is how to test it.

@mmahut Thanks, I didn't know about that tool.
The help has led me to stumble on nix-review pr 65150, and now I'm in a nix-shell, and I don't know how to continue...

Look around the shell, you will see a result symlink where you will find the binary, just run it from there.

I added wrapQtAppsHook to nativeBuildInput, ran nix-review wip -p qutebrowser in this branch and got the same error.
Am I doing it right?

I think the python wrapper is possibly intefering with the hook. I'll look into it

probably need #56354

Yes, we need to get the new pyqt5 in.

#64720 (comment) blocks scripts from being wrapped.

Adding wrapQtAppsHook only address plugins, such as xcb, not loading. It does not address the missing PyQt5.QtQml module. According to a working build of qutebrowser, that module is actually missing from PyQt5. This can be seen by comparing the PyQt5 referenced by working and non-working builds of qutebrowser. In the working build you'll see the files QtQml.pyi and QtQml.so in `/nix/store/PyQt/lib/python*/site-packages/PyQt5/. In the non-working build those two files will not be present. In fact, I recall seeing other missing files, such as QtWebEngine.

Let's try again after #65836 is in.