Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cherrypy: fix build #65217

Merged
merged 8 commits into from Jul 23, 2019
Merged

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 21, 2019

Motivation for this change

Fixes #65030
cc: @sjau

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner July 21, 2019 09:42
@marsam
Copy link
Contributor Author

marsam commented Jul 21, 2019

@GrahamcOfBorg build pythonPackages.cherrypy python3Packages.cherrypy flexget

@marsam
Copy link
Contributor Author

marsam commented Jul 21, 2019

@GrahamcOfBorg build pythonPackages.cherrypy python3Packages.cherrypy flexget

@marsam
Copy link
Contributor Author

marsam commented Jul 21, 2019

@GrahamcOfBorg build pythonPackages.cherrypy python3Packages.cherrypy flexget

@marsam
Copy link
Contributor Author

marsam commented Jul 21, 2019

@GrahamcOfBorg build pythonPackages.cherrypy python3Packages.cherrypy flexget

@marsam marsam merged commit c248435 into NixOS:master Jul 23, 2019
@marsam marsam deleted the fix-cherrypy-build branch July 23, 2019 01:03
@johanot
Copy link
Contributor

johanot commented Jul 23, 2019

python3Packages.cherrypy is broken in 19.03 too it looks like. Any relation to this? Can this PR be backported as is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flexget/cherrypy fails to build
4 participants