Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli: fix the tests by patching pyyaml #65134

Merged
merged 1 commit into from Jul 20, 2019
Merged

awscli: fix the tests by patching pyyaml #65134

merged 1 commit into from Jul 20, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jul 20, 2019 •
edited

Motivation for this change

The check phase of the pyyaml dependency of awscli was failing due to running the tests with a newer version of libyaml.

closes #65129

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
awscli: fix the tests by patching pyyaml
ee0405c 
The checkPhase of the pyyaml dependency of awscli was failing due to
running the tests with a newer version of libyaml.

closes NixOS#65129
@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

@GrahamcOfBorg build awscli

@kalbasit kalbasit merged commit 784efe7 into NixOS:master Jul 20, 2019
@kalbasit kalbasit deleted the nixpkgs_fix-awscli-pyyaml-test branch July 20, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

awscli overriden dependency pyyaml tests are failing
2 participants
@kalbasit @FRidh