Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rescuetime: 2.14.2.1 -> 2.14.3.1 #65243

Merged
merged 1 commit into from Jul 22, 2019
Merged

rescuetime: 2.14.2.1 -> 2.14.3.1 #65243

merged 1 commit into from Jul 22, 2019

Conversation

steshaw
Copy link
Member

@steshaw steshaw commented Jul 21, 2019 •
edited

  • Updated the hashes.
  • Tested on amd64.

This is my first contribution. As such, I'm not sure if I need to follow the items in "Things done". I was just installing rescuetime this morning. Let me know if I need to do something further.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@steshaw steshaw changed the title rescuetime: 2.14.2.1 => 2.14.3.1 rescuetime: 2.14.2.1 -> 2.14.3.1 Jul 21, 2019
@ofborg ofborg bot requested a review from cstrahan July 21, 2019 22:17
mmahut
mmahut approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@globin globin merged commit f90a1b9 into NixOS:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@steshaw @mmahut @globin