Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: Fix dark theme #65156

Merged
merged 1 commit into from Jul 20, 2019
Merged

slack: Fix dark theme #65156

merged 1 commit into from Jul 20, 2019

Conversation

Gonzih
Copy link
Contributor

@Gonzih Gonzih commented Jul 20, 2019

Motivation for this change

slack-dark was broken by #61328
ajax calls are not allowed to local fs in electron, fs module has to be used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Jul 20, 2019
Merged
Merged
@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 20, 2019

Tagging people who reviewed original PR that caused the issue @NeQuissimus @joachifm
Please take a look when you have some time.

Thanks!

angristan
angristan approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, I can confirm it fixes slack-dark

mmahut
mmahut approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, it fixes the theme.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 20, 2019

Thanks for the reviews!

@NeQuissimus NeQuissimus merged commit 8a2c182 into NixOS:master Jul 20, 2019
@NeQuissimus
Copy link
Member

Thank you!

@Gonzih Gonzih deleted the gonzih/fix-slack-dark branch July 20, 2019 13:44
@NeQuissimus
Copy link
Member

Tangentially related, has the thread view always been broken under dark theme? Text is light gray on white background :D

@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 20, 2019 •
edited

I think it worked at some point.
Somewhat related: since theme is a separate package and slack devs really like to change markup in UI some issues will be popping up due to outdated theme CSS.

@NeQuissimus
Copy link
Member

Updated the theme and threads are working again: 8f99ec0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angristan angristan angristan approved these changes

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gonzih @NeQuissimus @mmahut @angristan