New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utsushi: init at 3.57.0 #65223
utsushi: init at 3.57.0 #65223
Conversation
33c7e0b
to
511ca4e
Compare
Thanks for your review, @jtojnar. I will wait for @thedavidmeister feedback before applying your suggestions, though. |
@thedavidmeister this version should not require imagemagick in $PATH. Can you test it ? |
latest is that
and
|
|
I won't have time to try other things this week, unfortunately. Try what @yegortimoshenko said, or attach a debugger on xsane, break on |
oh, by the way, after you rebuilt with the new version, did you reboot ? |
@symphorien @yegortimoshenko i probably did not reboot, here is the latest xsane
utsushi
looks good! |
You mean that scanning works with xsane, despite the error messages ? |
@symphorien yeah it all seems to work fine to me on both i'm not expert but i've got PDFs popping out so 🤷♂️ |
Great! |
@@ -0,0 +1,3 @@ | |||
absolute-path-to-convert.patch | |||
print-errors.patch | |||
absolute_path_for_tesseract.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the patches have to be modified in the future (there are updates of this driver, the last one was this year) it will be easier to do this with quilt and this file. But I agree this is a very small advantage.
*/ | ||
|
||
stdenv.mkDerivation rec { | ||
pname = "imagescanv3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably match the package name (utsushi
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Alternatively, this package could use the "community source" at | ||
https://gitlab.com/utsushi/utsushi/ | ||
Epson provides proprietary plugins for networking, ocr and some more | ||
scanner models. Those are not (yet ?) packaged here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be easier to upstream these patches to a community fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to build the community sources (autoconf fails with
configure.ac:54: error: possibly undefined macro: AS_IF
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:205: error: possibly undefined macro: AC_MSG_ERROR
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrahamcOfBorg build utsushi |
Motivation for this change
#64985
Things done
Completely untested as I don't have access to the corresponding hardware.
@thedavidmeister can you test this and probably fix the problem you encounter ?
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)