Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb: update packages #65222

Merged
merged 9 commits into from Sep 9, 2019
Merged

mariadb: update packages #65222

merged 9 commits into from Sep 9, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 21, 2019 •
edited

Motivation for this change

Move packages connector-c and galera to external. Need to will the package appear on https://nixos.org/nixos/packages.html
Update package galera to v25.3.27
Add packages:

  • connector-c v3.1.2
  • galera v26.4.2
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin force-pushed the connector-c branch 6 times, most recently from 655b4e8 to 1d336c5 Compare July 21, 2019 13:36
@ttuegel ttuegel removed their request for review July 21, 2019 15:33
@Izorkin Izorkin force-pushed the connector-c branch 2 times, most recently from 6b4fcfd to ce16ea4 Compare July 21, 2019 16:14
@FRidh
Copy link
Member

FRidh commented Jul 27, 2019

In order to achieve that one could also simply use inherit (foo) bar;. Was this approach agreed upon somewhere?

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 27, 2019

@FRidh nowhere approach agreed.
After wanted to divide mariadb into separate packages to mariadb-server and mariadb-client
#64132
#63723

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 27, 2019 •
edited

In order to achieve that one could also simply use inherit (foo) bar;

I don't know how to use this variant

@FRidh
Copy link
Member

FRidh commented Jul 28, 2019

@GrahamcOfBorg eval

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 28, 2019

@FRidh not need rename mysql.connector-c to libmysql? Probably it will be so clearer.

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 18, 2019

@GrahamcOfBorg build mariadb-connector-c_2_3 mariadb-connector-c_3_1 mariadb-galera_25 unixODBCDrivers.mariadb
@GrahamcOfBorg test gitea mysql mysql-backup mysql-replication

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 18, 2019

@GrahamcOfBorg build mariadb-connector-c_3_1

@aanderse
Copy link
Member

@Izorkin it looks like some tests aren't properly evaluating, if I'm not mistaken:

The following builds were skipped because they don't evaluate on x86_64-linux: tests.mysql-backup, tests.mysql-replication

Any idea?

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 20, 2019

@GrahamcOfBorg test mysql-backup mysql-replication

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 20, 2019

@GrahamcOfBorg test mysqlBackup mysqlReplication
@GrahamcOfBorg test gitea mysql

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 20, 2019

Оn my server tests gitea mysql mysqlBackup correct work.
For the test mysqlReplication need this PR #61671

disassembler
disassembler suggested changes Aug 31, 2019
View reviewed changes
pkgs/servers/sql/mariadb/connector-c/2_3.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/mariadb/connector-c/3_1.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/mariadb/galera/25.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/mariadb/galera/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@Izorkin Izorkin force-pushed the connector-c branch 2 times, most recently from 00bd2b4 to 0018d9a Compare August 31, 2019 10:57
@Izorkin
Copy link
Contributor Author

Izorkin commented Sep 9, 2019

Rebased PR

Mic92
Mic92 reviewed Sep 9, 2019
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -3873,7 +3873,9 @@ in {

monotonic = callPackage ../development/python-modules/monotonic { };

MySQL_python = callPackage ../development/python-modules/mysql_python { };
MySQL_python = callPackage ../development/python-modules/mysql_python {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a pr to remove this package: #68354

@Mic92 Mic92 mentioned this pull request Sep 9, 2019
Merged
10 tasks
@Mic92 Mic92 merged commit 791ac31 into NixOS:staging Sep 9, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Sep 9, 2019

Thanks!

@Izorkin Izorkin deleted the connector-c branch September 9, 2019 14:44
@dtzWill dtzWill mentioned this pull request Sep 23, 2019
Closed
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 23, 2019
@Mic92 @dtzWill
Merge pull request NixOS#65222 from Izorkin/connector-c
6ffc9d2 
mariadb: update packages
(cherry picked from commit 791ac31)
@Izorkin Izorkin mentioned this pull request Oct 9, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@disassembler disassembler disassembler requested changes

@aanderse aanderse aanderse approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@FRidh FRidh Awaiting requested review from FRidh

@peti peti Awaiting requested review from peti

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: lua 6.topic: python 6.topic: qt/kde 6.topic: ruby 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Izorkin @FRidh @Mic92 @aanderse @lheckemann @disassembler