mysql80: init at 8.0.17 #65221
Merged
mysql80: init at 8.0.17 #65221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL 8.0 is a significant iteration after MySQL 5.7. This patch adds it as a parallel build alongside mysql57 (similar to mysql56 and mysql55 before).
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
aanderse
requested changes
Aug 4, 2019
orivej
reviewed
Aug 4, 2019
Note: "MySQL Router" is a distinct component. Building it fails on macOS 10.12.6 with an error (below); hence, it is skipped.
```
[ 98%] Building CXX object router/src/plugin_info/src/CMakeFiles/mysqlrouter_plugin_info.dir/library_file.cc.o
[ 98%] Building CXX object router/src/plugin_info/src/CMakeFiles/mysqlrouter_plugin_info.dir/main.cc.o
[ 98%] Building CXX object router/src/plugin_info/src/CMakeFiles/mysqlrouter_plugin_info.dir/plugin_info_app.cc.o
[ 98%] Building CXX object router/src/plugin_info/src/CMakeFiles/mysqlrouter_plugin_info.dir/plugin.cc.o
[ 98%] Linking CXX executable ../../../../runtime_output_directory/mysqlrouter_plugin_info
[ 98%] Built target mysqlrouter_plugin_info
Scanning dependencies of target rest_api_lib
[ 98%] Building CXX object router/src/rest_api/src/CMakeFiles/rest_api_lib.dir/rest_api_utils.cc.o
[ 98%] Linking CXX static library librest_api_lib.a
[ 98%] Built target rest_api_lib
Scanning dependencies of target rest_api
[ 98%] Building CXX object router/src/rest_api/src/CMakeFiles/rest_api.dir/rest_api_component.cc.o
In file included from /tmp/nix-build-mysql-8.0.17.drv-0/mysql-8.0.17/router/src/rest_api/src/rest_api_component.cc:30:
/tmp/nix-build-mysql-8.0.17.drv-0/mysql-8.0.17/router/src/rest_api/src/rest_api_plugin.h:90:8: error: 'shared_timed_mutex' is unavailable: introduced in macOS 10.12
std::shared_timed_mutex rest_api_handler_mutex_;
^
/nix/store/3r156gjbpig7xav3crnhffn3msnqmak7-libc++-7.1.0/include/c++/v1/shared_mutex:204:58: note: 'shared_timed_mutex' has been explicitly marked unavailable here
class _LIBCPP_TYPE_VIS _LIBCPP_AVAILABILITY_SHARED_MUTEX shared_timed_mutex
^
1 error generated.
make[2]: *** [router/src/rest_api/src/CMakeFiles/rest_api.dir/build.make:63: router/src/rest_api/src/CMakeFiles/rest_api.dir/rest_api_component.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:10908: router/src/rest_api/src/CMakeFiles/rest_api.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/19c1b8qn0x8fnsa64y4k19r169ifv1b7-mysql-8.0.17.drv' failed with exit code 2
error: build of '/nix/store/19c1b8qn0x8fnsa64y4k19r169ifv1b7-mysql-8.0.17.drv' failed
```
Would skipping it be a regression? I don't think so: `mysqlrouter` was not
part of `mysql57`, and `mysql80` has not been previously published via
nixpkgs.
Alrighty, I've pushed up 585da78 to use 8.0.17. There was one snag with 8.0.17 -- the mysql8 source tree includes a bundled copy of |
aanderse
reviewed
Aug 6, 2019
|
I have cleaned it up and consider it ready to merge (as a single squashed commit). Some notes:
|
|
Looks nicer! I did a local sniff test with the latest revision - built on OSX, launched |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
MySQL 8.0 is a new shiny. Need mysql80 binaries so that we can start testing our app with it.
Related links:
The PR introduces version
8.0.168.0.17.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Other comments
This is my first submission to nixpkgs. It's just an adaptation of the
mysql57scripts, with updates for compiler compatibility.I've done very light testing (manually launching
mysqld; usingmysqlto create a small database+table).