Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxkbcommon: fix build on darwin with upstream patch #65086

Merged
merged 1 commit into from Jul 20, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

xkbcommon/libxkbcommon#101 got accepted upstream.
Made more sense to just fix the portability issue in the test program.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented Jul 20, 2019

I think this should go to staging to avoid mass rebuild on darwin

@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

up to 1000 packages is a lot but not that bad. Darwin bootstrapping is currently broken on staging-next and staging. Considering this isn't a critical fix it can just wait in staging-next :)

@FRidh FRidh changed the base branch from master to staging July 20, 2019 07:46
@FRidh FRidh changed the base branch from staging to staging-next July 20, 2019 07:46
@FRidh FRidh merged commit ecfb397 into NixOS:staging-next Jul 20, 2019
@worldofpeace worldofpeace deleted the libxkbcommon-patch branch July 20, 2019 15:03
@worldofpeace
Copy link
Contributor Author

Thanks @FRidh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants