Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify: 1.0.96.181 -> 1.1.5.153 #65081

Merged
merged 1 commit into from Jul 20, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Jul 19, 2019

Motivation for this change

Wow, Spotify hasn't been updated in a long time! Fonts look much better in this release.

Thanks to the update script, this was a bliss. There was a missing dependency (libatspi.so.0) which I fixed thanks to #49636.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@angristan angristan changed the title spotify: 1.0.96.181.gf6bc1b6b-12 -> 1.1.5.153.gf614956d-16 spotify: 1.0.96.181 -> 1.1.5.153 Jul 19, 2019
@ofborg ofborg bot requested review from timokau and edolstra July 19, 2019 14:56
@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

tested locally

@FRidh FRidh merged commit 3670450 into NixOS:master Jul 20, 2019
@timokau
Copy link
Member

timokau commented Jul 20, 2019

Did you actually play anything? There's #57800, and I don't think anything has changed.

@angristan
Copy link
Member Author

You're right I get a SIGSEGV when playing music. @FRidh Can you revert this? Thanks and sorry

@FRidh
Copy link
Member

FRidh commented Jul 21, 2019

Ah, no, that I did not. Reverting...

@angristan
Copy link
Member Author

Apparently the snap package has been updated to 1.10: https://www.omgubuntu.co.uk/2019/07/spotify-snap-app-outdated

Time to try again!

@angristan
Copy link
Member Author

Same SIGSEGV when playing music, sadly :(

@timokau
Copy link
Member

timokau commented Jul 28, 2019

Thanks for trying! I wonder if they don't test the builds or just don't care.

At least we're not bound to the latest version anymore since the switch to snapcraft. The latest version isn't that important as long as it still works.

@angristan angristan mentioned this pull request Jul 30, 2019
10 tasks
angristan added a commit to angristan/nixpkgs that referenced this pull request Aug 1, 2019
See NixOS#57800 and NixOS#65081 for discussion around fixing the SIGSEV since 1.1.5

Fix taken from
https://gitweb.gentoo.org/repo/gentoo.git/commit/media-sound/spotify?id=d8c8d8abd012c709551cc96802d2615fa69b5212:

Adding apulse libraries to LD_LIBRARY_PATH make spotify work
even if pulseaudio is not installed. If pulseaudio is installed
instead of apulse, this has no effect.

Adding APULSE_PLAYBACK_DEVICE is also necessary otherwise apulse does
not find the device (inspired by the tor-browser-bundle derivation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants