Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xygrib: init at 1.2.6.1 #65085

Merged
merged 1 commit into from Jul 23, 2019
Merged

xygrib: init at 1.2.6.1 #65085

merged 1 commit into from Jul 23, 2019

Conversation

johannesloetzsch
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

Thanks for your contribution!
I ran XyGrib and it seems to work (at least is opens a window).
I have left some comments, they are mostly minor.

@johannesloetzsch
Copy link
Contributor Author

johannesloetzsch commented Jul 21, 2019 •
edited

Thank you @symphorien and @JohnAZoidberg for your reviews :)
I applied all change requests.

JohnAZoidberg
JohnAZoidberg requested changes Jul 21, 2019
View reviewed changes
pkgs/applications/misc/xygrib/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/xygrib/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/xygrib/default.nix Outdated Show resolved Hide resolved
@JohnAZoidberg
Copy link
Member

Oh and you could rewrite the commit to use the same email address you added on GitHub. Then it associates your account with that commit.

@Mic92 Mic92 merged commit 471ff05 into NixOS:master Jul 23, 2019
@johannesloetzsch johannesloetzsch deleted the xygrib branch July 24, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johannesloetzsch @symphorien @JohnAZoidberg @Mic92