Add tootstream #65187
Closed
Add tootstream #65187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etu
reviewed
Jul 25, 2019
FRidh
requested changes
Jul 27, 2019
matthiasbeyer
force-pushed
the
add-tootstream
branch
from
f66b031
to
41240b0
Compare
|
This took me way to long, but I guess your annotations should be fixed now. |
etu
approved these changes
Aug 23, 2019
|
sadly this has a merge conflict |
|
So finally someone is interested in my one-year-old PR. That wouldn't have happened with a proper tool to handle these things (edit: And a proper workflow, that is), like sourcehut for example. Enough ranting, here goes the updated PR. |
matthiasbeyer
force-pushed
the
add-tootstream
branch
from
41240b0
to
392b864
Compare
Lassulus
reviewed
May 27, 2020
| sha256 = "1229wbckanp08bbqajsn31ggvay271d883nca28wpvsaqdsv8ci5"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ decorator six requests pytz dateutil python_magic ]; |
There was a problem hiding this comment.
I guess setuptools is missing here, because I'm getting this error:
[nix-shell:~/.cache/nixpkgs-review/pr-65187]$ tootstream
Traceback (most recent call last):
File "/nix/store/k2b74bln8j3hkmbqnaws3wdkv6dw4m3m-tootstream-0.3.7/bin/.tootstream-wrapped", line 6, in <module>
from tootstream.toot import main
File "/nix/store/k2b74bln8j3hkmbqnaws3wdkv6dw4m3m-tootstream-0.3.7/lib/python3.7/site-packages/tootstream/toot.py", line 22, in <module>
import pkg_resources # part of setuptools
ModuleNotFoundError: No module named 'pkg_resources'
jonringer
reviewed
May 27, 2020
Comment on lines
30
to
44
| meta = { | ||
| homepage = "https://github.com/halcy/Mastodon.py"; | ||
| description = "Python wrapper for the Mastodon API"; | ||
| license = lib.licenses.mit; | ||
| }; |
There was a problem hiding this comment.
please add yourself as a maintainer
matthiasbeyer
force-pushed
the
add-tootstream
branch
from
0d0658d
to
8f5b0d9
Compare
jonringer
reviewed
May 28, 2020
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
add-tootstream
branch
from
861a19d
to
788e164
Compare
|
I hate this "Apply suggestion" feature of github. Who invents such crap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I want to use this.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)