Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma5: allow to configure the default phonon backend #65188

Merged
merged 1 commit into from Jul 20, 2019
Merged

plasma5: allow to configure the default phonon backend #65188

merged 1 commit into from Jul 20, 2019

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Jul 20, 2019 •
edited

Motivation for this change

Introduce a new .plasma5.phononBackend option. Supported values:

  • gstreamer (default) installs the same packages as before
  • vlc installs only the vlc phonon backend

I went with an enum type to future-proof the option if more backends are packaged in the future.

Tested by looking at the output of nixos-rebuild dry-build with both values of this option, and with enableQt4Support on and off.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Reviewed points

From https://nixos.org/nixpkgs/manual/#reviewing-contributions-module-updates

  • changes are backward compatible
  • removed options are declared with mkRemovedOptionModule
  • changes that are not backward compatible are documented in release notes
  • module tests succeed on ARCHITECTURE
  • options types are appropriate
  • options description is set
  • options example is provided
  • documentation affected by the changes is updated (autogenerated)

@xvello
nixos/plasma5: allow to configure the default phonon backend
df748ae 
Introduce a new .plasma5.phononBackend option. Default value
"gstreamer" installs the same packages as before. "vlc" installs
only the vlc phonon backend.
@xvello xvello marked this pull request as ready for review July 20, 2019 20:05
@xvello
Copy link
Contributor Author

xvello commented Jul 20, 2019

Pinging @ttuegel as you are very active on this module.
This is my first contribution, suggestions are very welcome 🙇‍♂️

ttuegel
ttuegel approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@ttuegel ttuegel merged commit a071bfa into NixOS:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xvello @ttuegel @Janik-Haag