font-awesome_4: Readd, font-awesome_5: 5.9.0 -> 5.10.0 #65240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
force-pushed
the
fontawesome-4
branch
from
275a7a9
to
ae14fc9
Compare
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
The "nicer" way to solve this is a generic build function for font awesome that takes the version and sha256 as parameters (refer to to unifi or vala for some examples). Might also be good with a comment that explains why we have the _4 version. |
Mic92
reviewed
Jul 23, 2019
| let | ||
| version = "4.7.0"; | ||
| in fetchzip rec { | ||
| name = "font-awesome-${version}"; |
There was a problem hiding this comment.
Can you add a concrete example, why we have this package? Then we can reevaluate in future if we still need the old version.
Version 5 is incompatible for some icons, so projects that depend on it need to actively convert the symbols, see: greshake/i3status-rust#130 Reintroducing the old version lets us use those programs that haven't been updated. Was removed in 0a393f5
JohnAZoidberg
force-pushed
the
fontawesome-4
branch
from
ae14fc9
to
5374037
Compare
|
What about this? :) |
JohnAZoidberg
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version 5 is incompatible for some icons, so projects that depend on it
need to actively convert the symbols, see:
greshake/i3status-rust#130
Reintroducing the old version lets us use those programs that haven't
been updated.
Was removed in 0a393f5
cc @Mic92 and @baldo
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)