Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmwareLinuxNonfree: 2019-06-16 -> 2019-07-17 #65091

Merged
merged 1 commit into from Jul 21, 2019
Merged

firmwareLinuxNonfree: 2019-06-16 -> 2019-07-17 #65091

merged 1 commit into from Jul 21, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 19, 2019

Motivation for this change

I had this in a branch so yeah

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz July 19, 2019 17:20
@angristan
Copy link
Member

Typo in your commit and PR name: it's 2019-04-16 not 2019-06-16 🙂

@eadwu eadwu force-pushed the firmwareLinuxNonfree/update-1 branch from 6660141 to 0557007 Compare July 19, 2019 20:45
@dtzWill
Copy link
Member

dtzWill commented Jul 20, 2019

Been using similar commit, looks good to me!

fpletz
fpletz approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also have been testing this. 👍

@fpletz
Copy link
Member

fpletz commented Jul 21, 2019

@GrahamcOfBorg build firmwareLinuxNonfree

@fpletz fpletz merged commit e467600 into NixOS:master Jul 21, 2019
@fpletz fpletz mentioned this pull request Jul 22, 2019
Closed
10 tasks
@georgewhewell georgewhewell mentioned this pull request Sep 16, 2019
Closed
@eadwu eadwu deleted the firmwareLinuxNonfree/update-1 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @angristan @dtzWill @fpletz