New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.diofant: init at 0.10.0 #65234
Conversation
The package should be disabled on Python 2.7. |
9046b05 passes |
@GrahamcOfBorg build python3Packages.diofant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
This pull request has been mentioned on Nix community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't vertically align the =
in meta
. It's a style that isn't maintained in nixpkgs.
Additionally, the declaration of testing dependencies in the expression looks incomplete
- https://github.com/diofant/diofant/blob/v0.10.0/setup.cfg#L40
- https://github.com/diofant/diofant/blob/v0.10.0/setup.cfg#L58
I we don't want to run the tests because they take an hour, why have anything
tests related in the expression at all?
Commit msg should be |
These are setup dependencies. Should I put all of them in |
Not sure what |
Thanks @suhr. The last little fixup/code style thing I pushed 👍 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)