Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.diofant: init at 0.10.0 #65234

Merged
merged 1 commit into from Jul 29, 2019
Merged

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jul 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
Copy link
Member

smaret commented Jul 22, 2019

nix review pr on Darwin gives the following error (the same would most likely occur on Linux/NixOS):

  ERROR: Diofant requires Python '>=3.5' but the running Python is 2.7.16

The package should be disabled on Python 2.7.

@smaret
Copy link
Member

smaret commented Jul 22, 2019

9046b05 passes nix-review pr on Darwin. I also ran some examples from the documentation and it appears to run fine.

@smaret
Copy link
Member

smaret commented Jul 22, 2019

@GrahamcOfBorg build python3Packages.diofant

Copy link
Member

@smaret smaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/40

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't vertically align the = in meta. It's a style that isn't maintained in nixpkgs.

Additionally, the declaration of testing dependencies in the expression looks incomplete

I we don't want to run the tests because they take an hour, why have anything
tests related in the expression at all?

pkgs/development/python-modules/diofant/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/diofant/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/diofant/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/diofant/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/diofant/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

Commit msg should be pythonPackages.diofant: init at 0.10.0.

@suhr
Copy link
Contributor Author

suhr commented Jul 27, 2019

I we don't want to run the tests because they take an hour, why have anything
tests related in the expression at all?

These are setup dependencies. Should I put all of them in nativeBuildInputs?

@worldofpeace
Copy link
Contributor

I we don't want to run the tests because they take an hour, why have anything
tests related in the expression at all?

These are setup dependencies. Should I put all of them in nativeBuildInputs?

Not sure what these is in this context. If something is a setup_requires it would translate to nativeBuildInputs.

@worldofpeace worldofpeace changed the title diofant: init at 0.10.0 pythonPackages.diofant: init at 0.10.0 Jul 27, 2019
@worldofpeace
Copy link
Contributor

Thanks @suhr.

The last little fixup/code style thing I pushed 👍

@suhr suhr deleted the diofant branch July 29, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants