Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klystrack: init at 1.7.6 #65236

Merged
merged 1 commit into from Jul 24, 2019
Merged

klystrack: init at 1.7.6 #65236

merged 1 commit into from Jul 24, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jul 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

symphorien
symphorien approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nix-review, it builds and opens a window when run. The windows flickers, but if it is a bug, it is unlikely to be caused by packaging so LGTM.

@suhr
Copy link
Contributor Author

suhr commented Jul 21, 2019

The flickering is a known bug: kometbomb/klystrack#250

worldofpeace
worldofpeace suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has icons and desktop files in the repo that should be installed and patched.

pkgs/applications/audio/klystrack/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/klystrack/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/klystrack/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/klystrack/default.nix Outdated Show resolved Hide resolved
@suhr
Copy link
Contributor Author

suhr commented Jul 24, 2019

r?

@worldofpeace
Copy link
Contributor

@suhr I think we should probably include this patch kometbomb/klystrack@bb53759 for #65236 (review)

@suhr
Copy link
Contributor Author

suhr commented Jul 24, 2019

I don't know how to include a patch in a derivative.

@worldofpeace
Copy link
Contributor 

patches = [
  (fetchpatch {
    url = "https://github.com/kometbomb/klystrack/commit/bb537595d02140176831c4a1b8e9121978b32d22.patch";
    sha256 = lib.fakeSha256; # replace
  })
];

@worldofpeace
Copy link
Contributor

Docs

@worldofpeace worldofpeace merged commit 90ccc1c into NixOS:master Jul 24, 2019
worldofpeace
worldofpeace approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@suhr suhr deleted the klystrack branch July 24, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhr @worldofpeace @symphorien