Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/syncthing: do not use nogroup #65078

Merged
merged 1 commit into from Jul 24, 2019
Merged

nixos/syncthing: do not use nogroup #65078

merged 1 commit into from Jul 24, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

We were already creating a group for the user under which to run syncthing but
we were defaulting to running as nogroup.

Additionally, use install instead of multiple calls to mkdir/cp/chown.

Cc: @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
nixos/syncthing: do not use nogroup
8317663 
We were already creating a group for the user under which to run syncthing but
we were defaulting to running as `nogroup`.

Additionally, use `install` instead of multiple calls to mkdir/cp/chown.
@peterhoeg peterhoeg merged commit bede985 into NixOS:master Jul 24, 2019
@peterhoeg peterhoeg deleted the f/st branch July 24, 2019 05:22
@rasendubi rasendubi mentioned this pull request Jul 29, 2019
Merged
10 tasks
@aanderse aanderse mentioned this pull request Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @flokli @aanderse