Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broot: 0.8.0 -> 0.9.0 #65076

Merged
merged 1 commit into from Jul 24, 2019
Merged

broot: 0.8.0 -> 0.9.0 #65076

merged 1 commit into from Jul 24, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jul 19, 2019

Motivation for this change

https://github.com/Canop/broot/releases/tag/v0.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @magnetophon

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nox-review happy, binary works, non-nixos linux x86_64, macos 10.13

@magnetophon
Copy link
Member

Works on NixOS too!

@markuskowa
Copy link
Member

@markuskowa markuskowa merged commit 0300fc5 into NixOS:master Jul 24, 2019
@dywedir dywedir deleted the broot branch July 24, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants