Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune: 1.10.0 -> 1.11.0 #65127

Merged
merged 1 commit into from Jul 24, 2019
Merged

dune: 1.10.0 -> 1.11.0 #65127

merged 1 commit into from Jul 24, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 20, 2019

Motivation for this change

Changelog: https://github.com/ocaml/dune/releases/tag/1.11.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vbgl July 20, 2019 02:49
vbgl
vbgl requested changes Jul 22, 2019
View reviewed changes
pkgs/development/tools/ocaml/dune/default.nix
src = fetchurl {
url = "https://github.com/ocaml/dune/releases/download/${version}/dune-${version}.tbz";
sha256 = "15fx9rg16g7ig43rg4sdq0wp0br5h1mjxxgv8b15s317vqlfc5pd";
url = "https://github.com/ocaml/dune/releases/download/${version}/dune-build-info-${version}.tbz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the hash is wrong now.

Copy link
Contributor Author

@marsam marsam Jul 24, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated the hash.
About the .tbz name seems to be related to ocaml/dune#2224, and it is the same that dune declares in the opam archive https://github.com/ocaml/opam-repository/pull/14567/files#diff-a081995843fd7c2880ab94240401e49bR48

@ofborg ofborg bot requested a review from vbgl July 24, 2019 12:13
@vbgl
Copy link
Contributor

vbgl commented Jul 24, 2019

@GrahamcOfBorg build pyre

@vbgl vbgl merged commit 236d744 into NixOS:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @vbgl