Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik: 1.7.10 -> 1.7.12 #65198

Merged
merged 1 commit into from Jul 21, 2019
Merged

traefik: 1.7.10 -> 1.7.12 #65198

merged 1 commit into from Jul 21, 2019

Conversation

ngerstle
Copy link
Contributor

@ngerstle ngerstle commented Jul 20, 2019

Motivation for this change

Traefik has some bugs blocking some work for me, in particular traefik/traefik#4840, fixed by traefik/traefik#4910, and included in v1.7.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jul 21, 2019

@GrahamcOfBorg build traefik

Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@Mic92 Mic92 merged commit f86ee80 into NixOS:master Jul 21, 2019
@ngerstle ngerstle deleted the update-traefik branch July 21, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants