Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suil: 0.10.0 -> 0.10.6 #65153

Merged
merged 1 commit into from Jan 20, 2020
Merged

suil: 0.10.0 -> 0.10.6 #65153

merged 1 commit into from Jan 20, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jul 20, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste July 20, 2019 11:08
@mmahut
Copy link
Member

mmahut commented Jul 20, 2019

@GrahamcOfBorg build suil

@markuskowa
Copy link
Member

nix-review reveals that this breaks ingen:

builder for '/nix/store/cvlbvwvnpljsgcgaw2js6p6vcin9vs02-ingen-unstable-2017-07-22.drv' failed with exit code 1; last 10 log lines:
  Build failed
   -> task in 'libingen_client' failed (exit status 1): 
  	{task 140737335887312: cxx PluginModel.cpp -> PluginModel.cpp.1.o}
[...]

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg build ingen

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Fails to build.

@magnetophon magnetophon changed the title suil: 0.10.0 -> 0.10.4 suil: 0.10.0 -> 0.10.6 Jan 20, 2020
@magnetophon magnetophon mentioned this pull request Jan 20, 2020
Merged
10 tasks
@magnetophon
Copy link
Member Author

ingen builds now: #78102

@teto
Copy link
Member

teto commented Jan 20, 2020 

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/65153
6 package built:
ardour audacity ingen jalv qtractor suil

@teto teto merged commit 50c3ac2 into NixOS:master Jan 20, 2020
@magnetophon magnetophon deleted the suil branch January 20, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @mmahut @markuskowa @teto