haskellPackages.zip-archive: disable tests #65255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As a fix for unzip CVE-2019-13232 (#64909) we are not checking for potential zip bombs, which is causing one of the
haskellPackages.zip-archive
tests to fail, as it's using potentially overlapping files in their zip tests.We are working with upstream jgm/zip-archive#57 to fix this issue, but meanwhile we are going to disable
haskellPackages.zip-archive
failed tests due to this regression.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)