Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.zip-archive: disable tests #65255

Merged
merged 1 commit into from Jul 22, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 22, 2019

Motivation for this change

As a fix for unzip CVE-2019-13232 (#64909) we are not checking for potential zip bombs, which is causing one of the haskellPackages.zip-archive tests to fail, as it's using potentially overlapping files in their zip tests.

We are working with upstream jgm/zip-archive#57 to fix this issue, but meanwhile we are going to disable haskellPackages.zip-archive failed tests due to this regression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from basvandijk as a code owner July 22, 2019 09:28
@FRidh FRidh merged commit 16dec39 into NixOS:staging-next Jul 22, 2019
@mmahut mmahut deleted the zip-archive branch July 22, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants