Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ripgrep: turn withPCRE2 on by default #65254

Merged
merged 1 commit into from Jul 22, 2019
Merged

ripgrep: turn withPCRE2 on by default #65254

merged 1 commit into from Jul 22, 2019

Conversation

ar1a
Copy link
Contributor

@ar1a ar1a commented Jul 22, 2019 •
edited

Motivation for this change

This is set by default in archpkgs and debian repos, and would confuse fewer new users

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ar1a @worldofpeace
ripgrep: turn withPCRE2 on by default
94e6256 
This is set by default in archpkgs and debian repos, and would confuse
fewer new users.
@worldofpeace worldofpeace merged commit b93b7d2 into NixOS:master Jul 22, 2019
@worldofpeace
Copy link
Contributor

Thanks ✨

@adisbladis
Copy link
Member

I was wondering about the closure size implications of this PR. The ripgrep binary is inflated by 0.9M (previous 5.0M, now 5.9M) with no extra runtime dependencies. 👍

@worldofpeace
Copy link
Contributor

I was wondering also, doesn't sound too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ar1a @worldofpeace @adisbladis