Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brewtarget: init at 2.3.1 #65253

Merged
merged 1 commit into from Jul 22, 2019
Merged

brewtarget: init at 2.3.1 #65253

merged 1 commit into from Jul 22, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 22, 2019

Motivation for this change

init at 2.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to package this as described in the qt section of the nixpkgs manual

Note that's the unstable build because it's changed on master.

@mmahut
Copy link
Member Author

mmahut commented Jul 22, 2019

@worldofpeace thank you for your suggestion! Rebased.

@mmahut
Copy link
Member Author

mmahut commented Jul 22, 2019

@worldofpeace rebased.

worldofpeace
worldofpeace approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds and executes. Traversed the output directory structure.

@worldofpeace worldofpeace merged commit 0c9acb1 into NixOS:master Jul 22, 2019
@mmahut mmahut deleted the brewtarget branch July 22, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @worldofpeace