Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghidra: 9.0 -> 9.0.2 #65177

Merged
merged 3 commits into from Jul 24, 2019
Merged

ghidra: 9.0 -> 9.0.2 #65177

merged 3 commits into from Jul 24, 2019

Conversation

rgarza
Copy link
Contributor

@rgarza rgarza commented Jul 20, 2019

Motivation for this change

Update version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [X ] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jul 20, 2019

If you would, please change your commit message to : ghidra: 9.0 -> 9.0.2

@rgarza rgarza changed the title Update default.nix ghidra: 9.0 -> 9.0.2 Jul 20, 2019
@mmahut
Copy link
Member

mmahut commented Jul 21, 2019

@rgarza I think Graham meant the git commit message, not the pull request title, you need to amend it and force push.

@mmahut
Copy link
Member

mmahut commented Jul 21, 2019

@GrahamcOfBorg build ghidra

@markuskowa
Copy link
Member

@rgarza can you please squash your commits into a single commit.

@Mic92 Mic92 merged commit f882547 into NixOS:master Jul 24, 2019
@Mic92
Copy link
Member

Mic92 commented Jul 24, 2019

squashed on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rgarza @grahamc @mmahut @markuskowa @Mic92 @Janik-Haag