Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate iobuf submodule names #158

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

nakengelhardt
Copy link
Contributor

Fixes #157.

Vendor files create a lot of IObufs with duplicate names:

    m.submodules[pin.name] = Instance(...)

which is no longer allowed as of 698b005.

This appends a suffix for each bit:

for bit in range(len(p_port)):
    m.submodules["{}_{}".format(pin.name, bit)] = Instance(...)

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #158 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #158     +/-   ##
=========================================
- Coverage   80.92%   80.73%   -0.2%     
=========================================
  Files          32       32             
  Lines        5216     5232     +16     
  Branches     1133     1133             
=========================================
+ Hits         4221     4224      +3     
- Misses        858      873     +15     
+ Partials      137      135      -2
Impacted Files Coverage Δ
nmigen/hdl/ast.py 85.97% <0%> (-1.25%) ⬇️
nmigen/back/pysim.py 95.63% <0%> (-0.61%) ⬇️
nmigen/hdl/ir.py 94.38% <0%> (+0.01%) ⬆️
nmigen/tracer.py 95% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698b005...9fa2585. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submodule named 'ddr2_0__a' already exists after 698b005 with Atlys
2 participants