Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] gtk3: don't multiout demos #65237

Merged
merged 1 commit into from Jul 22, 2019
Merged

[staging-next] gtk3: don't multiout demos #65237

merged 1 commit into from Jul 22, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 21, 2019 •
edited

Motivation for this change

Noticed that pantheon.elementary-gsettings-schemas was failing on staging-next.
After checking the copy commands it was doing I noticed there was no gsettings
in gtk3.out!

moveToOutput share/gsettings-schemas "$dev" was doing this.

After reflection I found this approach on multioutputs to be flimsy.
Perhaps a patch would be better to use in the future.

this needs to be merged to staging-next to avoid that aforementioned regression
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from FRidh July 21, 2019 19:11
@ofborg ofborg bot requested review from 7c6f434c and vcunat July 21, 2019 19:31
@7c6f434c
Copy link
Member

Darwin problem is at stdenv level

@worldofpeace worldofpeace merged commit da6101d into NixOS:staging-next Jul 22, 2019
@worldofpeace worldofpeace deleted the dont-multiout-demos branch July 22, 2019 16:28
@vcunat
Copy link
Member

vcunat commented Jul 27, 2019

👍 the difference in disk usage is negligible (160k addition to 36M of .out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @7c6f434c @vcunat