Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: 0.72.0 -> 0.73.0 #65266

Merged
merged 1 commit into from Jul 23, 2019
Merged

rubocop: 0.72.0 -> 0.73.0 #65266

merged 1 commit into from Jul 23, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 22, 2019

Motivation for this change

Changelog: https://github.com/rubocop-hq/rubocop/releases/tag/v0.73.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Jul 22, 2019 •
edited

How did you create this change? From what I can see in the upstream diff, there should be deps changes, too. I'd expect you would have to run bundix --magic with the upstream Gemfile.

@marsam
Copy link
Contributor Author

marsam commented Jul 23, 2019

yes, I used bundix --magic, which IIUC it only bumps runtime dependencies https://rubygems.org/gems/rubocop#runtime_dependencies

@globin globin merged commit 0142252 into NixOS:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @globin