Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pandas: 0.24.2 -> 0.25 #65264

Closed
wants to merge 1 commit into from
Closed

Conversation

teto
Copy link
Member

@teto teto commented Jul 22, 2019

Drops python2 support
https://pandas.pydata.org/pandas-docs/stable/whatsnew/v0.25.0.html

It solves a few bugs they had introduced in 0.24 in my program (but surely introduces many more...)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner July 22, 2019 12:55
@FRidh
Copy link
Member

FRidh commented Jul 22, 2019

536341c

@teto
Copy link
Member Author

teto commented Jul 22, 2019 via email

@teto teto deleted the pandas_25 branch September 5, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants