Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sublime-merge: 1107 -> 1116, sublime-merge-dev: 1111 -> 1115 #65110

Merged
merged 3 commits into from Jul 21, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Screenshot from 2019-07-19 18 20 48

Couldn't screenshot the sublime-merge-dev changelog because it was too long, however you can view it by launching the application and selecting Help -> Changelog...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

cc @zookatron

@jollheef
Copy link
Member

Tested locally. Works on my machine.

@worldofpeace worldofpeace merged commit ee5bcff into NixOS:master Jul 21, 2019
@worldofpeace worldofpeace deleted the smerge-update branch July 21, 2019 01:11
@zookatron
Copy link
Contributor

Sorry for the delay in responding, this is great, thanks @worldofpeace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants