Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME3 updates #65113

Merged
merged 10 commits into from Jul 22, 2019
Merged

GNOME3 updates #65113

merged 10 commits into from Jul 22, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 19, 2019

Motivation for this change

See commit msg.

Commits tentative for reviews are

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but LGTM

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jul 22, 2019

@GrahamcOfBorg build gnome3.ghex

@worldofpeace
Copy link
Contributor Author

Rebase was 3c9046f making appstream-glib a checkInputs in ghex.
And some patches for ghex so it builds on darwin.

@ofborg ofborg bot requested review from matthewbauer and hedning July 22, 2019 17:43
@worldofpeace worldofpeace merged commit d8d85ae into NixOS:master Jul 22, 2019
@worldofpeace worldofpeace deleted the gnome-updates branch July 22, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants