boot tests: fix globbing in qemu configuration #65214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the refactoring for IPXE the configuration was literal perl code and included a call to `glob`. After refactoring it became a map of strings, where those strings contained the old perl code. Ultimately this was passing perl fragements to the shell interpreting the qemu command line. To restore the globbing behaviour, we can inject the equivalent shell glob.
This was referenced Jul 22, 2019
|
Argh. My initial intention was precisely to save Perl code injection behavior but because I somehow forgot to run non-netboot tests this happened. I propose to restore the old behavior instead, see #65259. |
|
In the end I removed all globbing and use an attribute instead, which seems the best solution to me. Closing this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the refactoring for IPXE the configuration was literal perl
code and included a call to
glob. After refactoring it became a mapof strings, where those strings contained the old perl
code. Ultimately this was passing perl fragements to the shell
interpreting the qemu command line. To restore the globbing behaviour,
we can inject the equivalent shell glob.
Motivation for this change
Fix boot tests. Note that these tests won't pass without #65212.
For the record, I think injecting shell into the qemu command line through perl is a terrible idea, but it seems like the smallest change to restore the tests.
Tested:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)