zsh-powerlevel10k init at 2019-07-28 #65246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Provide a fast, drop in replacement for zsh-powerlevel9k
zyradyl
changed the title
|
I have updated the version being used per #65431, I'll update every seven days till merger. 馃槃 |
ryantm
reviewed
Jan 4, 2020
| @@ -5859,6 +5859,15 @@ | |||
| github = "zraexy"; | |||
| name = "David Mell"; | |||
| }; | |||
| zyradyl = { | |||
There was a problem hiding this comment.
Please separate the maintainer addition into a separate commit.
| in | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "powerlevel10k-${version}"; |
There was a problem hiding this comment.
Suggested change
| name = "powerlevel10k-${version}"; | |
| pname = "powerlevel10k"; | |
| version = "2019-07-28"; |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "romkatv"; | ||
| repo = "powerlevel10k"; |
There was a problem hiding this comment.
Suggested change
| repo = "powerlevel10k"; | |
| repo = pname; |
|
@GrahamcOfBorg build zsh-powerlevel10k |
|
I assume this is superseded by #76386. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
zsh-powerlevel9k can increase latency with large git repositories. Powerlevel10k is a drop in replacement that decreases that latency.
Additionally, I have added myself to the maintainers file. I am planning on (fingers crossed) submitting more than just this pull, so I hope this is appropriate. 馃槄
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)