Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.openapi-spec-validator: init at 0.2.7 #65244

Merged
merged 1 commit into from Jul 29, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 21, 2019

Motivation for this change

Adds a useful OpenAPI spec validator tool.

Things done

Tested the program built against pythonPackages and python3Packages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @vanschelven (swagger_spec_validator) and @Shou (openapi-generator-cli)

@rvl rvl requested a review from FRidh as a code owner July 21, 2019 23:32
rvl added a commit to input-output-hk/iohk-nix that referenced this pull request Jul 22, 2019
This tool can be used within CI to validate swagger specs.

I have also opened a PR on Nixpkgs:
NixOS/nixpkgs#65244
iohk-bors bot added a commit to input-output-hk/iohk-nix that referenced this pull request Jul 23, 2019
140: Add package for openapi-spec-validator r=jbgi a=rvl

This tool can be used within CI to validate swagger specs.

I have also opened an upstream PR NixOS/nixpkgs#65244.


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
@FRidh
Copy link
Member

FRidh commented Jul 27, 2019

@GrahamcOfBorg build python3Packages.openapi-spec-validator

@worldofpeace worldofpeace merged commit ff2a72b into NixOS:master Jul 29, 2019
@worldofpeace
Copy link
Contributor

Thank you @rvl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants