Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fxlinuxprint: init at 1.1.2-1 #65196

Merged
merged 2 commits into from Jul 22, 2019
Merged

fxlinuxprint: init at 1.1.2-1 #65196

merged 2 commits into from Jul 22, 2019

Conversation

delan
Copy link
Member

@delan delan commented Jul 20, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 21, 2019
View reviewed changes
pkgs/misc/cups/drivers/fxlinuxprint/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/fxlinuxprint/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/fxlinuxprint/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/fxlinuxprint/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/fxlinuxprint/default.nix Outdated Show resolved Hide resolved
worldofpeace
worldofpeace suggested changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree Output

├── etc
│   └── cups
│       ├── mimefx.convs
│       └── mimefx.types
├── lib
│   └── cups
│       └── filter
│           ├── pdftopdffx
│           ├── pdftopjlfx
│           └── pstopdffx
└── share
    ├── cups
    │   └── model
    │       └── fxlinuxprint.ppd.gz
    ├── doc
    │   └── fxlinuxprint
    │       ├── changelog.Debian.gz
    │       └── copyright
    └── ppd
        └── FujiXerox

12 directories, 8 files

Do we really need to install the stuff at share/doc? Doesn't look like useful docs.

@delan
Copy link
Member Author

delan commented Jul 22, 2019

fixed in 68012d74369cbc7ba1c7db0b947b193a17e8ae1a

% tree /nix/store/l4pnni4crw0rv3ykcyyq0hrrxgpdyp25-fxlinuxprint-1.1.2-1
/nix/store/l4pnni4crw0rv3ykcyyq0hrrxgpdyp25-fxlinuxprint-1.1.2-1
├── etc
│   └── cups
│       ├── mimefx.convs
│       └── mimefx.types
├── lib
│   └── cups
│       └── filter
│           ├── pdftopdffx
│           ├── pdftopjlfx
│           └── pstopdffx
└── share
    └── cups
        └── model
            └── fxlinuxprint.ppd.gz

8 directories, 6 files

worldofpeace
worldofpeace approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash your commits.

It's also a good practice make a separate commit adding yourself to the maintainers list

maintainers: add delan

@delan
Copy link
Member Author

delan commented Jul 22, 2019

@worldofpeace thanks for guiding me through my first PR!

@worldofpeace
Copy link
Contributor

@delan Happy to hear that 💖

@worldofpeace worldofpeace merged commit c470619 into NixOS:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: printing 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delan @worldofpeace @Janik-Haag