Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/httpd: replace ssmtp with system-sendmail #59056

Merged
merged 1 commit into from Apr 6, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 6, 2019

Motivation for this change

Currently mod_php won't work with postfix.

cc @Ekleog as the maintainer of system-sendmail

Things done

Tested using php mail function in mod_php using both networking.defaultMailServer and services.postfix.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

cc @globin @etu as maintainers for PHP if you know whether there would be issues with a sendmail in path that always fail.

Context: currently if directDelivery isn't set then there is no sendmail in path. Following this change, even if directDelivery is set, there will be a sendmail in path, but it will fail unless there is a sendmail globally installed.

@aanderse
Copy link
Member Author

aanderse commented Apr 6, 2019

@Ekleog if no real sendmail is installed the apache error logs simply output the error from system-sendmail.

@Ekleog
Copy link
Member

Ekleog commented Apr 6, 2019

OK, let's merge, then. Thank you!

@Ekleog Ekleog merged commit 07fdcb3 into NixOS:master Apr 6, 2019
@aanderse
Copy link
Member Author

aanderse commented Apr 6, 2019

Great thanks! Can we cherry pick to 19.03? If not now then after the freeze/release?

@Ekleog
Copy link
Member

Ekleog commented Apr 6, 2019

Right, it's now in 19.03 67bc63f :)

I haven't backported to 18.09 as it sounds like too much risk for the benefit, given everyone has been living with the issue for months now :)

@aanderse
Copy link
Member Author

aanderse commented Apr 6, 2019

Agreed, thanks!

@aanderse aanderse deleted the mod_php-sendmail branch April 6, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants