Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.qcef: init at 1.1.4.6 #59092

Merged
merged 1 commit into from Apr 7, 2019
Merged

deepin.qcef: init at 1.1.4.6 #59092

merged 1 commit into from Apr 7, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 7, 2019 •
edited

Motivation for this change

Add qcef (Qt5 binding of Chromium Embedded Framework) to nixpkgs. It is a dependency for the forthcoming deepin-manual package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo mentioned this pull request Apr 7, 2019
Closed
76 tasks
@zimbatm zimbatm merged commit ac7d039 into NixOS:master Apr 7, 2019
@romildo romildo deleted the upd.deepin.qcef branch April 7, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @zimbatm @GrahamcOfBorg