Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7c7ded1a8bb0
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6516cb8d6f02
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 3, 2019

  1. gateware.i2c: load new data after each byte is read. 

    Also, fix testbench to release SDA after writing a bit.
    @whitequark
    whitequark committed Apr 3, 2019
    Copy the full SHA
    6e44cfb View commit details

Commits on Apr 4, 2019

  1. gateware.i2c: fix fencepost error in reads. 

    The ACK period would be interpreted as starting one bit time too
early, and SDA would be released. Not only that is a fencepost error,
but releasing SDA during the sample half-period is illegal; it would
be correctly detected as a stop condition, terminating trasnaction.

This commit reworks the read part of the FSM to only change SDA level
during setup half-period, and fixes the fencepost error.
    @whitequark
    whitequark committed Apr 4, 2019
    Copy the full SHA
    6516cb8 View commit details
Loading