Fix web_test pointerevent_coordinates_when_locked on wpt #16265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 4, 2019
The test was failing on WPT[1] because test driver only takes integer coordinates, but the test was using getBoundingClientRect which returns float values. This CL changes the test to set the "origin" for test driver actions so that there is no need to use getBoundingClientRect. [1] https://wpt.fyi/results/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html Change-Id: I56b2c052805b3bc174573564d176d6660accd7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553645 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#647877}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1553645
branch
from
fd0cb60
to
8ea9611
Compare
|
Following tests failed at Firefox Nightly /pointerevents/pointerlock/pointerevent_coordinates_when_locked.html
Unstable results
::: Running tests in a loop 10 times : FAIL |
|
Note: Already contacted the author |
|
@KyleJu is there a tracking bug? I don't see any follow-up commits to this test in Chromium. |
Oops sorry missed it. Let me address it now |
|
This PR fixed a syntax error on pointerlock test that was previously failing [https://wpt.fyi/results/?label=master&product=chrome%5Bexperimental%5D&product=edge&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&aligned&q=pointerevents%2Fpointerlock%2Fpointerevent_coordinates_when_locked]. Doesn't introduce any new flakiness. Admin merge @Hexcles ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing on WPT[1] because test driver only takes integer
coordinates, but the test was using getBoundingClientRect which
returns float values.
This CL changes the test to set the "origin" for test driver actions
so that there is no need to use getBoundingClientRect.
[1] https://wpt.fyi/results/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html
Change-Id: I56b2c052805b3bc174573564d176d6660accd7cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553645
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647877}