Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

munt: init at 2.3.0 #59027

Merged
merged 1 commit into from May 4, 2019
Merged

munt: init at 2.3.0 #59027

merged 1 commit into from May 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2019

Motivation for this change

A multi-platform software synthesiser emulating pre-GM MIDI devices such as the Roland MT-32, CM-32L, CM-64 and LAPC-I.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost closed this Apr 5, 2019
@ghost ghost reopened this Apr 6, 2019
matthiasbeyer
matthiasbeyer requested changes Apr 9, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@matthiasbeyer
Copy link
Contributor

Build for me, if the remaining comment is answered I'd approve.

@infinisil
Copy link
Member

@GrahamcOfBorg build munt

@bignaux
Copy link
Contributor

bignaux commented May 4, 2019

Please use quotes around URLs. We might remove unquoted syntax: NixOS/rfcs#45

@ghost
Copy link
Author

ghost commented May 4, 2019

@bignaux Done, thanks!

@Lassulus Lassulus merged commit 50d54c6 into NixOS:master May 4, 2019
@ghost
Copy link
Author

ghost commented May 4, 2019

@Lassulus Thank you!

@ghost ghost deleted the munt branch May 4, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthiasbeyer @infinisil @bignaux @Lassulus @GrahamcOfBorg