Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curseradio: init at 0.2 #58970

Merged
merged 1 commit into from
Apr 5, 2019
Merged

curseradio: init at 0.2 #58970

merged 1 commit into from
Apr 5, 2019
+49 −0

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Apr 4, 2019

Motivation for this change

Wanting curseradio in the repo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 4, 2019
@worldofpeace
Copy link
Contributor

Note that some people like to align the = vertically like you've done, but it's not really enforced throughout the tree. So it would be best if new additions didn't follow that pattern.

worldofpeace
worldofpeace suggested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the above comments.

Most were stylistic and the only issue was with using a patch verses substituteInPlace

@eyJhb eyJhb force-pushed the curseradio branch 2 times, most recently from 2578193 to 0629977 Compare April 5, 2019 07:39
@eyJhb
Copy link
Member Author

eyJhb commented Apr 5, 2019

@worldofpeace everything should be as requested now!
I always hate those patches, as some want it X way, others want it Y way .. ;)

@worldofpeace
Copy link
Contributor

I always hate those patches, as some want it X way, others want it Y way .. ;)

Indeed other people have their preference, but for hardcoding executables, you'll see that it's almost the preferred way in nixpkgs.

@eyJhb @worldofpeace
curseradio: init at 0.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
alyssais Alyssa Ross
GPG key ID: C4844408C0657052
Expired
Verified
Learn about vigilant mode
810df3f
@eyJhb
Copy link
Member Author

eyJhb commented Apr 5, 2019

I will just start doing it this way from now on out, seeing as I always end up doing it this way in the end. :)

@worldofpeace worldofpeace merged commit c794bda into NixOS:master Apr 5, 2019
@worldofpeace
Copy link
Contributor

Thanks for your contribution @eyJhb ❇️

@eyJhb
Copy link
Member Author

eyJhb commented Apr 5, 2019

Thanks for reviewing it! ;)

@eyJhb eyJhb mentioned this pull request Apr 7, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyJhb @worldofpeace @GrahamcOfBorg