Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joplin: init at 1.0.124 (CLI note-taking app, cc joplin-desktop) #59097

Merged
merged 3 commits into from Apr 17, 2019
Merged

joplin: init at 1.0.124 (CLI note-taking app, cc joplin-desktop) #59097

merged 3 commits into from Apr 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 7, 2019

Motivation for this change

I didn't know joplin-desktop had a CLI (terminal) program, too?!

Package it, woohoo!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Apr 7, 2019

I didn't know this app existed. Checked out our branch, built, and then ran (on NixOS 64bit). All good. 👍

@dtzWill dtzWill merged commit fd8bf47 into NixOS:master Apr 17, 2019
@dtzWill dtzWill deleted the feature/joplin-cli branch April 17, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @aanderse @GrahamcOfBorg