Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3blocks: 1.4 -> unstable-2019-02-07 #59099

Merged
merged 1 commit into from Apr 7, 2019
Merged

i3blocks: 1.4 -> unstable-2019-02-07 #59099

merged 1 commit into from Apr 7, 2019

Conversation

ilikeavocadoes
Copy link
Contributor

Motivation for this change

Updated i3blocks. The maintainer has stopped publishing releases (last one was 4 years ago), but develops the project actively. Since I'm updating to a commit in the master branch of the project, rather than a new version number, what should I put as the commit message and version for the package?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CrazedProgrammer
Copy link
Contributor

CrazedProgrammer commented Apr 7, 2019 •
edited

The standard way to do it would be version = "unstable-YYYY-MM-DD";, and the commit message i3blocks: 1.4 -> unstable-YYYY-MM-DD, with the date referring to the date that the commit was made.

I'm not sure if it's valuable to keep the 1.4 version in nixpkgs. Now that I see it, the package also lacks a maintainer.

matthiasbeyer
matthiasbeyer approved these changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did:

git fetch https://github.com/ilikeavocadoes/nixpkgs i3blocks
git checkout FETCH_HEAD
nix-build -A i3blocks

And it worked.

@ilikeavocadoes ilikeavocadoes changed the title WIP: i3blocks: 1.4 -> ? i3blocks: 1.4 -> unstable-2019-02-07 Apr 7, 2019
@ilikeavocadoes
Copy link
Contributor Author

ilikeavocadoes commented Apr 7, 2019 •
edited

I updated the version field to unstable-2019-02-07. If there are no other suggestions for improvements, this is ready to merge.

@xeji xeji merged commit c034fb3 into NixOS:master Apr 7, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/how-to-get-install-prefix-correct-with-autotools/2613/5

@OlivierMarty
Copy link

What happened to the scripts?

@OlivierMarty
Copy link

Ah, I see they were removed from upstream: vivien/i3blocks@0e395b9.
I'll consider packaging i3blocks-contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ilikeavocadoes @CrazedProgrammer @nixos-discourse @OlivierMarty @matthiasbeyer @GrahamcOfBorg @xeji