Fix: [Windows] OpenTTD window may be inactive when an error happens #7482
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
approved these changes
Apr 7, 2019
glx22
added
the
backport requested
PeterN
pushed a commit
to PeterN/OpenTTD
that referenced
this pull request
Apr 8, 2019
PeterN
pushed a commit
that referenced
this pull request
Apr 8, 2019
PeterN
added
backported
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OpenTTD window is inactive when a message box is displayed then input for OpenTTD window are not blocked, and subsequent message boxes are linked to the last displayed message box. If the error happens in a section of code where
_local_company != _current_companythe assert inHandleMouseEvents()will be triggered if mouse moves over OpenTTD window and there will be flood with message boxes. UsingMB_TASKMODALprevents that.Another option would be to use
_wnd.main_hwndfrom win32 video driver.